Don't suggest self-certification when not eligible. #4776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRyanSmith
approved these changes
Feb 11, 2025
jrobbins
force-pushed
the
20250211-dont-suggest-self-cert-when-not-eligible
branch
from
8546554 to
6bb5b08
Compare
jrobbins
deleted the
20250211-dont-suggest-self-cert-when-not-eligible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At yesterday's meeting with the privacy review team, they requested that we not display a dialog to nudge the feature owner toward self-certification when the survey question answers do not make that gate eligible for self-certification. Specifically, if a feature owner does not read and respond to the questions, then the privacy team wants them to go through full review rather than being prompted to read and respond.
In this PR: