Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use matrix.os instead of runner.os in artifact name #3797

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Feb 10, 2025

Description of proposed changes

Fixes error Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run on the ubuntu-24.04-arm job. Sample job failure at https://github.com/GenericMappingTools/pygmt/actions/runs/13231430400/job/36929163034#step:16:17

Patches #3778

Preview:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

Fixes error `Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run` on the ubuntu-24.04-arm job. Patches #3778
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 10, 2025
@weiji14 weiji14 added this to the 0.15.0 milestone Feb 10, 2025
@weiji14 weiji14 self-assigned this Feb 10, 2025
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@weiji14 weiji14 marked this pull request as ready for review February 10, 2025 01:59
@weiji14 weiji14 merged commit 21a2ae5 into main Feb 10, 2025
21 of 22 checks passed
@weiji14 weiji14 deleted the ci/runner_to_matrix_os branch February 10, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants