[Shopify] - Add Item As Variant Tests #4
+340
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinestaric
approved these changes
Oct 21, 2024
| @@ -0,0 +1,130 @@ | |||
| codeunit 139581 "Shpfy Create Item Variant Test" | |||
There was a problem hiding this comment.
I'm not sure what the agreement is on how thorough the tests should be. I see you're mainly doing unit tests on a level of a procedure. I'd also like to see a tests or two that handle the cases where Option > 1 and one for removing the default variant.
| VariantAPI: Codeunit "Shpfy Variant API"; | ||
| VariantId: BigInteger; | ||
| ActualQueryTxt: Text; | ||
| ExpexctedQueryTok: Label '{"query":"mutation {productVariantDelete(id: \"gid://shopify/ProductVariant/%1\") {deletedProductVariantId userErrors{field message}}}"}', Locked = true; |
There was a problem hiding this comment.
In this case, it's fine. as it's a small query, but I feel we'd be breaking these kinds of tests over time, as we change the queries in the actual app.
It might be better to only assert if the part of the query that you really care about is in it?
Like, you care that it contains productVariantDelete and your id, but you don't really care too much about the rest...
tinestaric
approved these changes
Oct 24, 2024
tinestaric
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Item As Variant Test
Automated tests for changes microsoft#26712