Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitor): provide valid exitcode #4155

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jusito
Copy link
Contributor

@jusito jusito commented Apr 1, 2023

break down of: #3836

Only the part where you would like to see logging to console and when for fn_script_ , I would need a hint for that.

@jusito
Copy link
Contributor Author

jusito commented Apr 2, 2023

regarding logging, read your comments on: #4156
I think this helped with my confusion of fn_script_log_* vs fn_print_*
In my testing environment I always have a log which contains only fn_print_* or the debug log. But basically fn_script_log is the overall logfile for lgsm.

  1. Do you want to add the fn_script_log_* , should I add them or do you want to not modify logging in this pr but rather later?

With this specific pr you can easily find issues in current servercodes, some of them I traced some time ago, many just dont open the queryport even if config is correct or have incorrect port config, or have missing queryport set and so on.

  1. Are you interested in fixing these in v23.2.0 or rather v23.2.1 or above?

I can look into it, I have a complete log of every servercode with this change applied, so I could start tracing it. But I would probably need a week for it. Some of my older fixes seems still fine for today, I would review them before again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants