Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ocaml/setup-ocaml@v2 #1324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

smorimoto
Copy link
Contributor

@smorimoto smorimoto commented Jun 8, 2021

From v2, the cache is enabled by default. Also, actions-ml is completely deprecated.

Signed-off-by: Sora Morimoto <[email protected]>
@@ -20,25 +20,15 @@ jobs:
env:
COQ_VERSION: ${{ matrix.coq }}
# coq-bits claims to support < 4.10 only
OCAML_VERSION: 4.09.1
OCAML_VERSION: 4.09.x
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows you to always use the latest point release.

Comment on lines -59 to +50
eval $(opam env)
coq_makefile -f _CoqProject -o Makefile.coq
make -j2
opam exec -- coq_makefile -f _CoqProject -o Makefile.coq
opam exec -- make -j2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use opam exec instead of eval $(opam env).

@lisanna-dettwyler lisanna-dettwyler self-assigned this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants