FEATURE: adding tests for monte carlo sims #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test suite for the Monte Carlo simulation pricing functionality to improve test coverage of option pricing features.
- Introduces tests for European call and put option pricing.
- Adds tests to validate error handling and simulation result consistency.
Comment on lines
+38
to
+39
| assert actual_price == expected_price | ||
|
|
There was a problem hiding this comment.
Floating point comparisons using '==' can be unreliable; consider using pytest.approx to avoid potential precision issues.
Suggested change
| assert actual_price == expected_price | |
| assert actual_price == pytest.approx(expected_price) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Comment on lines
+56
to
+57
| assert actual_price == expected_price | ||
|
|
There was a problem hiding this comment.
Using an exact equality check for floating point values may cause flaky tests due to precision errors; consider using pytest.approx for a more reliable comparison.
Suggested change
| assert actual_price == expected_price | |
| assert actual_price == pytest.approx(expected_price) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: