Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tinycore-linux.gns3a #918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s-celles
Copy link
Contributor

Before submitting a pull request, please check the following.


When updating an existing appliance:

  • The new version is on top.
  • The filenames in the "images" section are unique, to avoid appliances / version overwriting each other.
  • If you forked the repo, running check.py doesn't drop any errors for the updated file.

When creating a new appliance:

  • It's tested locally, i.e.
    • You dragged an instance into a project on your box, got it installed (if necessary), and did some basic network checks (ping, UI reachable, etc.).
    • GNS3 VM can run it without any tweaks.
    • The device is in the right category: router, switch, guest (hosts), firewall
    • You filled in as much info as possible (checks the schemas and other appliance files for some guidance).
  • When adding a container: it builds on Docker Hub and can be pulled.
  • The filenames in the "images" section are unique (to avoid appliances and/or versions overwriting each other).
  • If you forked the repo, running check.py doesn't drop any errors for the new file.
  • Optional: a symbol has been created for the new appliance.

@s-celles
Copy link
Contributor Author

This PR adds Core and CorePlus to TinyCore Linux appliance.

@grossmj
Copy link
Member

grossmj commented Sep 25, 2024

Thanks, I will test soon 👍

Copy link
Member

@grossmj grossmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version field in images must match the name field in versions.

For instance:

        {
            "filename": "linux-tinycore-11.1.qcow2",
            "version": "11.1",
            "md5sum": "00a65300a1dcc956e4e677c638bf4445",
            "filesize": 33816576,
            "download_url": "https://sourceforge.net/projects/gns-3/files/Qemu%20Appliances/",
            "direct_download_url": "http://downloads.sourceforge.net/project/gns-3/Qemu%20Appliances/linux-tinycore-11.1.qcow2"
        },
        {
            "name": "11.1",
            "images": {
                "hda_disk_image": "linux-tinycore-11.1.qcow2"
            }
        },

I understand you tried to add Core and CorePlus to this appliance. Maybe these 2 flavors should be separate appliances?

@s-celles
Copy link
Contributor Author

it could make sense as hardware requirements maybe different from a console only Linux distro to a Linux distro with GUI and some softwares

@grossmj
Copy link
Member

grossmj commented Sep 26, 2024

it could make sense as hardware requirements maybe different from a console only Linux distro to a Linux distro with GUI and some softwares

Yes, that's what I thought. Let's create separate appliances instead.

Thanks 👍

@grossmj grossmj closed this Sep 26, 2024
@grossmj
Copy link
Member

grossmj commented Oct 16, 2024

@scls19fr I was just wondering if you plan to create these separate appliances? Thanks.

@s-celles
Copy link
Contributor Author

Hi @grossmj

No. Sorry
I'm quite busy currently.

Kind regards

@grossmj
Copy link
Member

grossmj commented Oct 17, 2024

Ok no worries. I will try to take care of it myself.

@grossmj grossmj reopened this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants