Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E-Documents Core] - Enable deleting incorrect E-Documents #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AdeleStankeviciute
Copy link
Collaborator

@AdeleStankeviciute AdeleStankeviciute commented Jan 22, 2025

@AdeleStankeviciute AdeleStankeviciute changed the title [E-Documents Core] Enable deleting incorrect E-Documents [E-Documents Core] - Enable deleting incorrect E-Documents Jan 22, 2025
CreateIncomingEDocument(VendorNo, Enum::"E-Document Status"::"In Progress");
CreateIncomingEDocument(VendorNo, Enum::"E-Document Status"::"In Progress");

// [THEN] Get last E-Document
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a GIVEN no?

// [THEN] Get last E-Document
EDocument.FindLast();

// [THEN] Delete ok
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a WHEN

And a THEN would be an assert that EDocument no longer exists, or can also just be a comment that no error occured.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the GIVEN WHEN THEN on other tests as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants