Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E-Documents Core] - Sales attachments in Peppol #13

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AdeleStankeviciute
Copy link
Collaborator

Summary

Work Item(s)

Fixes #

@AdeleStankeviciute AdeleStankeviciute changed the title sales attachments in Peppol [E-Documents Core] - Sales attachments in Peppol Jan 30, 2025
tinestaric
tinestaric previously approved these changes Jan 30, 2025
tinestaric
tinestaric previously approved these changes Jan 30, 2025
EDocument.FindLast();
this.LibraryJobQueue.FindAndRunJobQueueEntryByRecordId(EDocument.RecordId);

// [THEN] Get xml file for this document
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You can join these two thens together.

basically, a THEN should explain what are we checking. What do we want to make sure has happened after WHEN has been executed.

GIVEN - EDocument Service is set to embed PDF to XML
GIVEN - Posted Invoice by a Team Member
WHEN - Export EDocument
THEN - PDF is embedded in the XML

It's okay that a When does a FindLast first, and then calls a the JobQueue. But the comments should really read like a test scenario. Like a story :P

@nerkel91
Copy link
Collaborator

nerkel91 commented Feb 7, 2025

Implementation

This new feature will allow automatic creation and embedding of Sales Invoice/Credit Memo PDFs into Peppol XML files when posting documents. This feature is controlled by new setting in the E-Document Service page.

  • New "Exported Parameters" FastTab added to the E-Document Service card.

  • New boolean "Embed Invoice PDF to XML" under "Exported Parameters" FastTab, allows users to enable or disable automatic invoice embedding.

  • When the setting enabled, the system creates and embeds a PDF invoice or credit memo automatically when posting a sales document.

  • The PDF follows the format defined in Report Selection - Sales.

  • The Peppol XML file with the embedded PDF is sent via E-Document Service.

This update makes invoicing more simple, reduces manual work, and enhances compliance with Peppol standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants