-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E-Documents Core] - Sales attachments in Peppol #13
base: main
Are you sure you want to change the base?
Conversation
EDocument.FindLast(); | ||
this.LibraryJobQueue.FindAndRunJobQueueEntryByRecordId(EDocument.RecordId); | ||
|
||
// [THEN] Get xml file for this document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You can join these two thens together.
basically, a THEN should explain what are we checking. What do we want to make sure has happened after WHEN has been executed.
GIVEN - EDocument Service is set to embed PDF to XML
GIVEN - Posted Invoice by a Team Member
WHEN - Export EDocument
THEN - PDF is embedded in the XML
It's okay that a When does a FindLast first, and then calls a the JobQueue. But the comments should really read like a test scenario. Like a story :P
Implementation This new feature will allow automatic creation and embedding of Sales Invoice/Credit Memo PDFs into Peppol XML files when posting documents. This feature is controlled by new setting in the E-Document Service page.
This update makes invoicing more simple, reduces manual work, and enhances compliance with Peppol standards. |
Summary
Work Item(s)
Fixes #