[E-Documents Core] - E-Invoice Preview FastTab #10
Conversation
| @@ -493,6 +500,7 @@ page 6121 "E-Document" | |||
| begin | |||
| IsProcessed := Rec.Status = Rec.Status::Processed; | |||
| IsIncomingDoc := Rec.Direction = Rec.Direction::Incoming; | |||
| ShowPreview := (Rec."Document Type" = Rec."Document Type"::"Purchase Invoice") or (Rec."Document Type" = Rec."Document Type"::"Purchase Credit Memo"); | |||
There was a problem hiding this comment.
nit, preference: you could also use "Document Type" in [Invoice, Credit Memo]. But this is really just a preference :P
| @@ -597,7 +605,7 @@ page 6121 "E-Document" | |||
| EDocumentHelper: Codeunit "E-Document Processing"; | |||
| ErrorsAndWarningsNotification: Notification; | |||
| RecordLinkTxt, StyleStatusTxt : Text; | |||
| ShowRelink, ShowMapToOrder, HasErrorsOrWarnings, HasErrors, IsIncomingDoc, IsProcessed, CopilotVisible : Boolean; | |||
| ShowRelink, ShowMapToOrder, HasErrorsOrWarnings, HasErrors, IsIncomingDoc, IsProcessed, CopilotVisible, ShowPreview : Boolean; | |||
There was a problem hiding this comment.
nit: This is getting a bit long...
| { | ||
| field("No."; Rec."No.") | ||
| { | ||
| ToolTip = 'Specifies what is being purchased.'; |
There was a problem hiding this comment.
move tooltips to the table
| @@ -0,0 +1,53 @@ | |||
| table 6100 "E-Invoice Line" | |||
| { | |||
| DataClassification = CustomerContent; | |||
There was a problem hiding this comment.
preference: I'd like to also see explicit property for extensible and accessible. Regardless if it's true or false. It means we thought about it and didn't just forget it. Same for pages.
| @@ -0,0 +1,43 @@ | |||
| page 6100 "E-Invoice Lines" | |||
| { | |||
| PageType = ListPart; | |||
| if not EInvoiceLine.IsEmpty() then | ||
| EInvoiceLine.DeleteAll(true); | ||
|
|
||
| if (EDocument."Document Type" <> EDocument."Document Type"::"Purchase Invoice") and (EDocument."Document Type" <> EDocument."Document Type"::"Purchase Credit Memo") then |
There was a problem hiding this comment.
nit, preference: not DocType in [Invoice, CrMemo]
| OnAfterPrepareReceivedDoc(EDocument, TempBlob, SourceDocumentHeader, SourceDocumentLine, TempEDocMapping); | ||
| end; | ||
|
|
||
| local procedure CreateEInvoiceLinesPreview(EDocument: Record "E-Document"; SourceDocumentLine: RecordRef) | ||
| var | ||
| EDocumentImportHelper: Codeunit "E-Document Import Helper"; |
| OnAfterPrepareReceivedDoc(EDocument, TempBlob, SourceDocumentHeader, SourceDocumentLine, TempEDocMapping); | ||
| end; | ||
|
|
||
| local procedure CreateEInvoiceLinesPreview(EDocument: Record "E-Document"; SourceDocumentLine: RecordRef) |
There was a problem hiding this comment.
nit: Hmm, this naming implies more of the "posting preview" behavior. So, actual lines would be created, but in the end reverted. Maybe CreateEInvoicePreviewLines? Would it be better to name the table accordingly as well?
|
|
||
| if SourceDocumentLine.FindSet() then | ||
| repeat | ||
| EInvoiceLine.Init(); |
There was a problem hiding this comment.
nit, preference: extract the content of the repeat loop into a local procedure, to make it cleaner.
| TempXMLBuffer.SetRange(Path, '/Invoice/cac:AccountingSupplierParty/cac:Party/cbc:EndpointID'); | ||
| TempXMLBuffer.FindFirst(); | ||
| TempXMLBuffer.Value := DocumentVendor."VAT Registration No."; | ||
| TempXMLBuffer.Modify(); |
|
Implementation This update allows users to preview incoming electronic invoices before creating a purchase document. The preview provides a non-editable view of invoice lines while header information remains in its existing section.
This feature provides users a quick and efficient way to review invoice details before creating purchase documents, ensuring accuracy and reducing manual errors. |
Implementation
This update allows users to preview incoming electronic invoices before creating a purchase document. The preview provides a non-editable view of invoice lines while header information remains in its existing section.
New FastTab "E-Invoice Lines" appears immediately below "Service Status" FastTab and is visible only if:
Direction = Incoming
Document Type = Invoice or Credit Memo
This feature provides users a quick and efficient way to review invoice details before creating purchase documents, ensuring accuracy and reducing manual errors.
MS PR: microsoft#27977