-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repair workflows integrationtests docker #1893
Open
MichaelsJP
wants to merge
33
commits into
feat/graph-repo-client
Choose a base branch
from
fix/repair-workflows-integrationtests-docker
base: feat/graph-repo-client
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: repair workflows integrationtests docker #1893
MichaelsJP
wants to merge
33
commits into
feat/graph-repo-client
from
fix/repair-workflows-integrationtests-docker
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
7 times, most recently
from
November 11, 2024 19:52
007a0e0
to
2b6d62a
Compare
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
3 times, most recently
from
November 11, 2024 20:16
7482a2b
to
e8ba8bf
Compare
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
2 times, most recently
from
November 12, 2024 11:37
f3ca464
to
bcecb7f
Compare
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
from
November 12, 2024 11:43
bcecb7f
to
797f64b
Compare
We already have a global function running before all that builds graphs. These extra builds just consume unnecessary time. Loading is sufficient.
We already have a global function running before all that builds graphs. These extra builds just consume unnecessary time. Loading is sufficient.
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
2 times, most recently
from
November 13, 2024 11:46
c29175d
to
2a22229
Compare
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
from
November 13, 2024 11:48
2a22229
to
4b64bf5
Compare
Ignores in subfolders should be named like this. The new buildkit versions will expect this.
…st resources The integration tests are heavy. Better cache what we can.
This allows for caching, even if the build fails.
…e is also needed per method call
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
4 times, most recently
from
November 14, 2024 01:53
c96d789
to
47a5ba3
Compare
MichaelsJP
force-pushed
the
fix/repair-workflows-integrationtests-docker
branch
from
November 14, 2024 07:55
47a5ba3
to
f756d86
Compare
At times the caching mechanics behave weird. It's better to keep them as a soft-fail part of the pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)