feat: Read country tags from an enriched PBF file #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoles
force-pushed
the
feat/read_countries_from_pbf
branch
4 times, most recently
from
1d2702e
to
a69c908
Compare
aoles
force-pushed
the
feat/read_countries_from_pbf
branch
2 times, most recently
from
5769eb0
to
07806d6
Compare
aoles
force-pushed
the
feat/read_countries_from_pbf
branch
from
07806d6
to
9be5ad3
Compare
The reduced travel time in the API test is because now the whole way rather than just its fragment is tagged with `footpath=crossing`. The crossing is necessary to pick up kerb height. Closes #1761
aoles
force-pushed
the
feat/read_countries_from_pbf
branch
from
341dcd2
to
dc279a2
Compare
aoles
force-pushed
the
feat/read_countries_from_pbf
branch
from
c72f45a
to
f237a65
Compare
aoles
force-pushed
the
feat/read_countries_from_pbf
branch
from
16087ed
to
5e14e96
Compare
aoles
force-pushed
the
feat/read_countries_from_pbf
branch
from
5e14e96
to
a76f643
Compare
The test routes got shorter because now when individual nodes rather than whole ways are labeled the accuracy of resolving countries increased.
The test doesn't pass with the car profile because now the profile relies on country data attached to nodes in the PBF file. The original border geometries are no longer processed by ORS so countries for virtual nodes/edges cannot be resolved anymore.
|
Circumvent issues with using the generic `nodeTags` hash map resulting in error: "Maximum array size exceeded for this load factor (elements: 536870912, load factor: 0.500000)".
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Changes to
testCountryExclusionapi testChanges to
testCountryExclusionapi testRequired changes to ors config (if applicable)
ors.engine.profiles.<profile_name>.ext_storages.Borders.preprocessed = true.