-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): Introduce reworked docker setup with jar #1670
Conversation
b9fa6e3
to
712d7fd
Compare
ab92529
to
41cd61c
Compare
44e919f
to
c1cd705
Compare
0328a95
to
6bf6763
Compare
…atest This ensures that users that checkout the compose from main will either fail or if it was cloned with the repo will have the latest repo stage build as their docker image. The image line is adjusted in the release action so that the release artifacts compose files will always point to their subsequent image version on docker hub.
Curl and openssl are not needed for the final image.
…the config loading messages The enhanced messages ensure that the user knows that a config is either read by ENV or as a fallback when existing in the config folder.
Curl is necessary for the health check in the docker-compose.yml
Wget is provided by default and can also be used for the health check. One dependency less :).
16a02ae
to
f643846
Compare
@koebi Cannot answer on your comments directly, so I'll answer it here:
Fixed. I moved them to its first usage in line 182.
Not really. It depends on how they read the documentation and what way they're configuring the container user. |
This PR introduces a completely overhauled docker setup. Due to the nature of the changes, the old docker setup isn't compatible with this one. No new major incompatibilities are to be expected soon.
By moving away from the old (almost 6-year-old docker structure) we now have the following features available:
ors.*.someting
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)