refactor: 온보딩 bevy 관련 로직 및 테스트 제거 #820
Merged
+4
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough변경 사항은 Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Warning Tool Failures:Tool Failure Count:Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
kckc0608
changed the title
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/main/java/com/gdschongik/gdsc/domain/member/domain/AssociateRequirement.java (1)
Line range hint
1-116: 아키텍처 개선 제안: 요구사항 상태 관리 최적화현재 각각의 상태(univStatus, discordStatus, infoStatus)가 개별적으로 관리되고 있습니다. 향후 요구사항이 추가되거나 변경될 때 더 유연하게 대응할 수 있도록 다음과 같은 개선을 고려해보시는 것은 어떨까요?
- 요구사항 타입을 enum으로 분리
- 상태를 Map으로 관리
- 검증 로직을 전략 패턴으로 구현
이러한 변경은 코드의 유연성과 확장성을 높일 수 있습니다.
예시 코드를 제공해드릴까요?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (14)
src/main/java/com/gdschongik/gdsc/domain/member/api/OnboardingMemberController.java(0 hunks)src/main/java/com/gdschongik/gdsc/domain/member/application/OnboardingMemberService.java(0 hunks)src/main/java/com/gdschongik/gdsc/domain/member/domain/AssociateRequirement.java(1 hunks)src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java(0 hunks)src/main/java/com/gdschongik/gdsc/domain/member/dto/MemberFullDto.java(0 hunks)src/main/java/com/gdschongik/gdsc/domain/member/dto/response/AdminMemberResponse.java(1 hunks)src/main/java/com/gdschongik/gdsc/global/exception/ErrorCode.java(0 hunks)src/test/java/com/gdschongik/gdsc/domain/member/dao/MemberRepositoryTest.java(0 hunks)src/test/java/com/gdschongik/gdsc/domain/member/domain/MemberTest.java(1 hunks)src/test/java/com/gdschongik/gdsc/domain/membership/domain/MembershipTest.java(0 hunks)src/test/java/com/gdschongik/gdsc/domain/membership/domain/MembershipValidatorTest.java(0 hunks)src/test/java/com/gdschongik/gdsc/domain/study/domain/StudyTest.java(0 hunks)src/test/java/com/gdschongik/gdsc/helper/FixtureHelper.java(0 hunks)src/test/java/com/gdschongik/gdsc/helper/IntegrationTest.java(0 hunks)
💤 Files with no reviewable changes (11)
- src/main/java/com/gdschongik/gdsc/domain/member/api/OnboardingMemberController.java
- src/main/java/com/gdschongik/gdsc/domain/member/application/OnboardingMemberService.java
- src/main/java/com/gdschongik/gdsc/domain/member/domain/Member.java
- src/main/java/com/gdschongik/gdsc/domain/member/dto/MemberFullDto.java
- src/main/java/com/gdschongik/gdsc/global/exception/ErrorCode.java
- src/test/java/com/gdschongik/gdsc/domain/member/dao/MemberRepositoryTest.java
- src/test/java/com/gdschongik/gdsc/domain/membership/domain/MembershipTest.java
- src/test/java/com/gdschongik/gdsc/domain/membership/domain/MembershipValidatorTest.java
- src/test/java/com/gdschongik/gdsc/domain/study/domain/StudyTest.java
- src/test/java/com/gdschongik/gdsc/helper/FixtureHelper.java
- src/test/java/com/gdschongik/gdsc/helper/IntegrationTest.java
🔇 Additional comments (4)
src/main/java/com/gdschongik/gdsc/domain/member/dto/response/AdminMemberResponse.java (1)
41-47: LGTM! Bevy 관련 로직이 깔끔하게 제거되었습니다.
RequirementDto에서 bevyStatus 필드가 제거되어 요구사항이 단순화되었습니다. 이는 PR의 목적인 Bevy 인증 로직 제거와 잘 부합합니다.
src/main/java/com/gdschongik/gdsc/domain/member/domain/AssociateRequirement.java (1)
34-38: 생성자 매개변수가 깔끔하게 정리되었습니다.
Bevy 관련 로직이 제거되면서 생성자가 더 간단하고 명확해졌습니다. 필수적인 상태 값만 남아있어 클래스의 책임이 더욱 명확해졌습니다.
src/test/java/com/gdschongik/gdsc/domain/member/domain/MemberTest.java (2)
Line range hint 1-322: 테스트 구조가 Bevy 제거 후에도 적절하게 유지되었습니다.
회원 상태 전이에 대한 핵심 테스트 케이스들이 잘 보존되어 있으며, Bevy 관련 검증이 제거된 후에도 다음 주요 시나리오들이 충분히 커버되고 있습니다:
- 게스트 회원가입
- 준회원 승급 조건 검증
- 정회원 승급 조건 검증
- 회원 탈퇴 및 정보 수정
323-323: 회원 강등 시 요구사항 초기화가 올바르게 검증됩니다.
비회원으로 강등 시 모든 준회원 가입 요구사항이 UNSATISFIED 상태로 초기화되는 것을 확인하는 테스트가 적절히 구현되어 있습니다.
Sangwook02
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타
Summary by CodeRabbit
기능 변경
버그 수정
테스트