Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement array repeat without repeating item at the AST/CST trees #6901

Merged
merged 11 commits into from
Feb 11, 2025

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Feb 6, 2025

Description

This PR is part of #6860.
In future PRs, we will need a way to declare array lengths that are not literals.

This PR enables this by postponing the length resolution to the type-check phase.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #6901 will not alter performance

Comparing xunilrj/typed-tree-array-repeat (163c3f2) with master (eafd99e)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj changed the title Implement array repeat without reapting the item at the AST/CST trees Implement array repeat without repeating item at the AST/CST trees Feb 7, 2025
@xunilrj xunilrj marked this pull request as ready for review February 7, 2025 16:15
@xunilrj xunilrj requested review from a team as code owners February 7, 2025 16:15
@xunilrj xunilrj self-assigned this Feb 7, 2025
@tritao tritao enabled auto-merge (squash) February 11, 2025 10:50
@tritao tritao merged commit 70c84ca into master Feb 11, 2025
41 checks passed
@tritao tritao deleted the xunilrj/typed-tree-array-repeat branch February 11, 2025 11:04
@xunilrj xunilrj mentioned this pull request Feb 12, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants