Update the php-openid library #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this with more and more PHP7 instances the constructor errors are spamming all error logs. With the latest commit from the php-openid repository those should be fixed: * openid/php-openid@d8ef0db
|
Thanks for your PR. Will review that asap. |
|
Regarding the "distant future". At least for TYPO3 7.6 we will have to keep patching the openid lib with our modifications, so a straight composer inclusion is out of scope. Can you please repush this PR and also adjust the |
|
I'll take care of the whole thing now. |
|
@sirdiego I'll close this one now as I made a lot new changes to the code, which included the upgrade of the upstream lib. Please test the new 7-0 branch if it works for you. Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this with more and more PHP7 instances the constructor
errors are spamming all error logs. With the latest commit from
the php-openid repository those should be fixed:
There is also a security patch within the current php-openid master.
Would be nice if in a distant future we can use the php-openid composer package, instead of packaging the lib inside the TYPO3 extension.