Skip to content

PHP Coding Standards #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

PHP Coding Standards #50

wants to merge 11 commits into from

Conversation

Spomky
Copy link

@Spomky Spomky commented Dec 26, 2013

This PR have a lot of changes, but it is just for coding standards.
I used php-cs-fixer, all levels (PSR-0 to PSR-2) and fixed inconsistant indentations (now all files have 4 spaces).

Spomky added 2 commits December 26, 2013 15:56
I used the PHP Coding Standards Fixer tool (php-cs-fixer).
Fixed inconsistant indentations (4 spaces).
* (optional) Scopes to be stored in space-separated string.
* The client associated with this authorization code.
* @param mixed $data
* Application data to associate with this authorization code, such as a User object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the description on the same line than the params instead of being on the next line ? (same in all places where this PR changes the indentation of the argument description)

Spomky and others added 9 commits December 26, 2013 22:19
Indentation fixed
Case for null, true and false fixed
- cleaned up OAuth2
- cleaned up OAuth2AuthenticateException
- cleaned up OAuth2RedirectException
- cleaned up OAuth2ServerException
- added missing @params
- added missing @param types
- added missing comment blocks
@alanbem
Copy link
Member

alanbem commented Dec 27, 2013

OAuth2/* classes and interfaces are done!

How do we split up OAuth2/Model/*? The are no phpDocs there so at least skeletal comments would be great.

@alanbem alanbem mentioned this pull request Feb 9, 2014
@alanbem
Copy link
Member

alanbem commented Feb 9, 2014

I fixed OAuth2/Model/* classes, rebased our work and squashed everything to your first commit. It is now on master via #54 !

Good Job!

@alanbem alanbem closed this Feb 9, 2014
@Spomky Spomky deleted the PHP-CS-FIXER branch February 12, 2014 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants