Additional language on dialpad #49
Conversation
|
Letters in both languages should be centered (e.g. 3 looks really bad).
|
|
@Aga-C also the height of the lowest row of keys is different, which looks weird. And also # and * are not vertically aligned with the 0, but this is also the case on the master branch. Might be a different PR? |
|
I've changed the string to a common one, and aligned the text to the center. I also aligned * and # to 0, though I'm not sure if it became better, need you opinion on this. |
|
|
Co-authored-by: HenriDellal <[email protected]>
|
Hi, are we waiting for something before merging? |
|
@Belyavin You have to wait for the final review from Naveen. |
Currently translated at 100.0% (69 of 69 strings) Translation: Fossify/Phone Translate-URL: https://hosted.weblate.org/projects/fossify/dialer/de/
Currently translated at 100.0% (69 of 69 strings) Translation: Fossify/Phone Translate-URL: https://hosted.weblate.org/projects/fossify/dialer/es/
Currently translated at 100.0% (69 of 69 strings) Translation: Fossify/Phone Translate-URL: https://hosted.weblate.org/projects/fossify/dialer/pl/
Currently translated at 100.0% (69 of 69 strings) Translation: Fossify/Phone Translate-URL: https://hosted.weblate.org/projects/fossify/dialer/zh_Hans/
Currently translated at 75.0% (3 of 4 strings) Translation: Fossify/Phone metadata Translate-URL: https://hosted.weblate.org/projects/fossify/dialer-metadata/pl/
Currently translated at 100.0% (4 of 4 strings) Translation: Fossify/Phone metadata Translate-URL: https://hosted.weblate.org/projects/fossify/dialer-metadata/de/
Currently translated at 100.0% (69 of 69 strings) Translation: Fossify/Phone Translate-URL: https://hosted.weblate.org/projects/fossify/dialer/bg/
Currently translated at 75.0% (3 of 4 strings) Translation: Fossify/Phone metadata Translate-URL: https://hosted.weblate.org/projects/fossify/dialer-metadata/it/
Currently translated at 91.3% (63 of 69 strings) Translation: Fossify/Phone Translate-URL: https://hosted.weblate.org/projects/fossify/dialer/fa/
Currently translated at 100.0% (69 of 69 strings) Translation: Fossify/Phone Translate-URL: https://hosted.weblate.org/projects/fossify/dialer/hr/
Currently translated at 75.0% (3 of 4 strings) Translation: Fossify/Phone metadata Translate-URL: https://hosted.weblate.org/projects/fossify/dialer-metadata/hr/
…ifyOrg#117) Co-authored-by: Naveen Singh <[email protected]>
|
|
||
| binding.settingsFontSize.text = getFontSizeText() | ||
| binding.settingsFontSizeHolder.setOnClickListener { | ||
| val items = arrayListOf( | ||
| RadioItem(FONT_SIZE_SMALL, getString(R.string.small)), | ||
| RadioItem(FONT_SIZE_MEDIUM, getString(R.string.medium)), | ||
| RadioItem(FONT_SIZE_LARGE, getString(R.string.large)), | ||
| RadioItem(FONT_SIZE_EXTRA_LARGE, getString(R.string.extra_large)) | ||
| ) | ||
|
|
||
| RadioGroupDialog(this@SettingsActivity, items, config.fontSize) { | ||
| config.fontSize = it as Int | ||
| binding.settingsFontSize.text = getFontSizeText() | ||
| } | ||
| } |
There was a problem hiding this comment.
Duplicated code from setupFontSize()
| public val letters = Array<String>(8) {""} | ||
| public val charMap = CharMap() |
| languages[LOCALE_EN] = lang | ||
| } | ||
|
|
||
| public var Initialized = false |
There was a problem hiding this comment.
The variable name should start with a lowercase letter. Another redundant public modifier.
| languages[lang] = language | ||
| } | ||
|
|
||
| Initialized = true; |
| if (lang != null && lang.charMap.containsKey(c)) { | ||
| res += lang.charMap[c] | ||
| } | ||
| else if (langEn != null && langEn.charMap.containsKey(c)) { |
There was a problem hiding this comment.
The code in DialpadT9.kt isn't properly formatted in many places.
| /** | ||
| * Read extra languages data from JSON | ||
| */ | ||
| public fun readFromJson(jsonText: String){ |
There was a problem hiding this comment.
There is no space between ) and {...
| @@ -60,9 +60,9 @@ | |||
| android:layout_below="@+id/dialpad_2" | |||
There was a problem hiding this comment.
The attribute android:layout_below is not valid in the LinearLayout. It's there in every button from dialpad_2_holder to dialpad_0_holder except the asterisk.
| @@ -271,9 +271,9 @@ | |||
| android:layout_height="wrap_content" | |||
| android:layout_centerInParent="true" | |||
There was a problem hiding this comment.
android:layout_centerInParent="true" is not valid in the LinearLayout.
| @@ -322,9 +322,9 @@ | |||
| android:layout_centerInParent="true" | |||
There was a problem hiding this comment.
android:layout_centerInParent="true" is not valid in the LinearLayout.
| @@ -343,5 +343,5 @@ | |||
| android:layout_centerInParent="true" | |||
There was a problem hiding this comment.
android:layout_centerInParent="true" is not valid in the LinearLayout.
@Belyavin indeed * and # look better when centered, I reverted that change. |
Fixes #47