-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Initial support for sim colors #27
base: master
Are you sure you want to change the base?
Conversation
@derrohrbach I'll check this soon... If the PR isn't ready to merge yet, you can convert it to a draft PR to signal that. |
@naveensingh Hey, thanks. I did not know that, since I'm used to the GitLab workflow where you just name your MR "WIP". |
b2576c8
to
ec04030
Compare
Only thing missing is moving the extension function to the common library. What is the workflow for that? Do I first submit a PR there and wait for a version to be built/published so i can update the reference in this project? Or should I just copy this one function over to the SMS app? |
Please raise a PR in Commons. Once the PR is merged, anyone can trigger a Jitpack build at this page: https://jitpack.io/#org.fossify/commons/ |
Here is my initial draft for sim color support. Feel free to already comment on it. Things left to do:
This fixes/implements: SimpleMobileTools/Simple-Dialer#322