Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #139 ignore white space character for search with dialpad numbers #214

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes #139 ignore white space character for search with dialpad numbers #214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa627e6
Fixes 139
Honk2 Jul 21, 2024
02097bc
fixes #139
Honk2 Jul 21, 2024
97555fa
Merge branch 'master' into fix-139
Honk2 Jul 25, 2024
1f4f140
Merge branch 'master' into fix-139
naveensingh Sep 28, 2024
f819866
Merge branch 'master' into fix-139
Honk2 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/kotlin/org/fossify/phone/activities/DialpadActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ class DialpadActivity : SimpleActivity() {
(binding.dialpadList.adapter as? ContactsAdapter)?.finishActMode()

val filtered = allContacts.filter {
var convertedName = PhoneNumberUtils.convertKeypadLettersToDigits(it.name.normalizeString())
var convertedName = PhoneNumberUtils.convertKeypadLettersToDigits(it.name.normalizeString()).filterNot { it.isWhitespace() }

if (hasRussianLocale) {
var currConvertedName = ""
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/kotlin/org/fossify/phone/adapters/ContactsAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.content.Intent
import android.content.pm.ShortcutInfo
import android.graphics.drawable.Icon
import android.net.Uri
import android.telephony.PhoneNumberUtils
import android.text.TextUtils
import android.util.TypedValue
import android.view.*
Expand Down Expand Up @@ -368,7 +369,7 @@ class ContactsAdapter(
if (name.contains(textToHighlight, true)) {
name.highlightTextPart(textToHighlight, properPrimaryColor)
} else {
name.highlightTextFromNumbers(textToHighlight, properPrimaryColor)
name.highlightTextFromNumbers(textToHighlight.replace('1', ' '), properPrimaryColor)
Copy link
Member

@naveensingh naveensingh Jul 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change is no longer needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I just messed up the commits.

}
}
}
Expand Down