Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocked messages from groupchats #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joers2
Copy link

@joers2 joers2 commented Aug 11, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Messages from groupchats weren't blocked when the recipient didn't have the senders number in their contactlist.

  • Added a setting where users can now toggle on/off if they want to receive messages in groupchats if they haven't got their number in the contaclist.
  • Added the logic for that in SmsReceiver.
  • Made the function for that setting in settingsactivity

Please contact me if you need me to adjust something!

Fixes the following issue(s)

Acknowledgement

In the activity_settings.xml I added a checkbox setting, to block messages from groupchats if you haven't stored the contacts.
I added a function in SettingsActivity.kt, for that button.
I added in Config.kt a variable boolean for that function.
I added in Constants.kt a const val for that function.
In SmsReceiver.kt I added the logic, so when the button is checked, the recipient won't receive messages from users if the number is not in the contactlist.
@Aga-C
Copy link
Member

Aga-C commented Aug 11, 2024

  1. It's a bug fix, there shouldn't be an option whether someone wants to have proper or wrong behavior.
  2. Have you tested if your bug fix works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Block messages from not stored contacts' does not block group chats from unknown numbers
2 participants