Added Asset, Colemak, Colemak-DH, Niro, Soul, and Workman layouts #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aga-C
reviewed
Aug 18, 2024
|
Thanks for contributing, but next time please create an issue or discussion first (as stated in the contribution guidelines). |
|
Apologies about not creating an issue first. It wasn't clear to me that I needed to do it (maybe make it a bit clearer?). It says to make sure that the new feature or bug is already reported and is open to pull requests, but does not mention that I should open an issue myself if one does not already exist. I'm not a native English speaker, so I apologize again if this was obvious and I misunderstood. Should I open an issue now? |
|
No need to open a new issue, just remember for the future 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Screenshots
Acknowledgement