Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Romanian layout #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tenextractor
Copy link

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Updated the Romanian layout to include the letters Ă Â Î Ș Ț as separate keys.

Before/After Screenshots/Screen Record

  • Before: No keys for Ă Â Î Ș Ț
  • After:
    image

Acknowledgement

@ionuttbara
Copy link

its kinda wrong. the î and â letters must be in first row. "o p ă î â"

@tenextractor
Copy link
Author

@ionuttbara The problem with that is that the keys in the top row would be too narrow. I want to maintain a maximum of 11 keys per row on phone keyboards.

@naveensingh
Copy link
Member

naveensingh commented Oct 25, 2024

I checked two other keyboards and they also have these additional keys buried as popup keys. Same goes for your other PRs #43 and #72.

Assuming you don't speak these languages, I would like to know what the native speakers think about this change before I merge.

@naveensingh naveensingh added the testers needed We need testers to test changes in this PR. label Oct 25, 2024
This was referenced Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testers needed We need testers to test changes in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants