-
Notifications
You must be signed in to change notification settings - Fork 692
[DRAFT] Fix: one-page ESM loading #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Just saw this PR, I should've looked before. But I just fixed this in main. Hopefully my approach was sufficient! |
I just pulled
and no loading... Perhaps we try to catch up this diff to |
I was sporadically seeing that error too. But I realized that most sporadic errors weren't failing in CI. So I made sure I was using |
I am seeing it in the chrome browser with no use of Node at all. I forget all the things I had to fix in this branch, but my guess is that there are probably still more fixes needed. The one page site should always load locally in a browser. |
external=
Tasks to still do:
TODO
s around FitText (we need to publish)