Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce vp/keyboard-shortcuts.folk #173

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Introduce vp/keyboard-shortcuts.folk #173

merged 3 commits into from
Sep 23, 2024

Conversation

cwervo
Copy link
Collaborator

@cwervo cwervo commented Sep 5, 2024

Instead of having the narrow esc-restart.folk this adds keyboard-shortcuts.folk and implements:

  • Alt + Esc to restart Folk
  • F1 to stop Folk completely

Feedback I'd like

  • Do these mappings make sense?

——-

@cwervo cwervo requested a review from osnr September 5, 2024 20:00
@ppkn
Copy link
Collaborator

ppkn commented Sep 5, 2024

I love it! I wish there were some existing pattern that people could easily map on to but I can't really think of anything.

Alt+F4 for stop feels really windows.

What's the Windows Key called again? That always has a system-level shortcut feel to me. 🪟+R for reload and 🪟+Esc for stopping? Just spitballing.

It seems pretty trivial to just have a shortcut reference at hand though so I'm fine with whatever shortcut you choose.

@cwervo cwervo merged commit ca64310 into main Sep 23, 2024
@cwervo cwervo deleted the shortcuts branch September 23, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants