Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stop medication bug #510

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Fix stop medication bug #510

merged 2 commits into from
Nov 6, 2018

Conversation

mgramigna
Copy link
Contributor

@mgramigna mgramigna commented Nov 6, 2018

Pull requests into Flux require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable (N/A) and ✅.

For Jira 1539 and the first bullet point of #506. We were trying to get the text typed before the "@" when selecting an active medication and the call we were making always returned empty string. Changing it to use the .text property of the anchor block fixes the bug.

To replicate the bug on master:

  • Open a new note
  • Type "#stop medication"
  • Type "@"
  • Do not type any other text and hit enter
  • Select a medication. The medication name will disappear and there will be a console error

Submitter:

Running the Application

  • Manually tested in Chrome
  • Manually tested in IE

Documentation

  • This pull request describes why these changes were made
  • Recognizes any potential shortcomings/bugs in the description
  • Cheat sheet is updated
  • Demo script is updated
  • Documentation on Wiki has been updated
  • Additional technical components and libraries are documented and added to wiki as needed

NoteParser

  • Note parser has been updated if structured phrases change

Code Quality

  • 4-space indents - convert any tabs to spaces
  • Use public class field syntax for binding functions - ex. handleChange = () => { ... };
  • Code is commented

Tests

  • Existing tests passed
  • Added Enzyme-UI tests for slim mode
  • Added Enzyme-UI tests for full mode
  • Added backend tests for new functionality added
  • Added note parser examples to test new functionality

Reviewer 1: Name

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Reviewer 2: Name

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Copy link
Contributor

@gregquinn2001 gregquinn2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgober sgober merged commit 94013f3 into master Nov 6, 2018
@sgober sgober deleted the fix-stop-med-bug branch November 6, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants