Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] only register (Sub)PageLanguageOverlayProvider if pagesLanguageConfigurationOverlay is activated #350

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

franzkugelmann
Copy link
Contributor

If setting pagesLanguageConfigurationOverlay = 0 then in this project all fluidpages configuration is done only in the default language. Thus the (Sub)PageLanguageOverlayProvider is not needed at all and in fact causes an error

Call to a member function getOption() on null

if the page_language_overlay record is edited.

I am not 100% sure if this assumption is correct, but solves the problem in my instance without creating other issues, as far as i can see.

@NamelessCoder
Copy link
Member

I did a little change to make sure the providers only load when the option is explicitly enabled. Honestly, I thought these providers were already excluded from loading when the option was off - it definitely isn't the intention to have those running if you disable that option!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants