Allow recording partial hints, make --record_hints settable #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtzguido
force-pushed
the
partial_hints
branch
2 times, most recently
from
a096cac to
5ca25d4
Compare
If the hint file fails to parse (e.g. is empty), Yojson will raise an exception. Handle it instead of crashing.
If we've generated hints for a subset of a file, this patch allows to combine the new hints with the old hints that are stored in disk, overriding the hints which have been regenerated and keeping the rest.
After previous patch, this now works fine to regenerate hints for only a few definitions, perhaps admitting the rest.
Incrementally, after every declaration. Crucially not after every repl_task, since they can be arbitrarilly long (e.g. check the entire file).
mtzguido
force-pushed
the
partial_hints
branch
from
5ca25d4 to
c08d670
Compare
|
Now updated to write out hints in the interactive mode too: after checking each declaration we perform a flush, updating the on-disk file with new information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on #3703)
This PR allows to turn on --record_hints in the middle of a file, and record hints for only that top-level. All old hints are retained, except where overriden by the new ones. This is done by reading the old hints_db and overriding with the new hints_db before writing the new file.
If --record_hints is given for the entire file, we ignore the old hints and write a fresh file.
Internally there a few simplication like always using the with_hints_db wrapper, removing some branching on Options.record_hints().
Note: in the IDE, the hints file is not written out as we never "finish" checking a module. This PR does not change this.