Add ability to specify grpc host #18193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl-bvl
force-pushed
the
feature/grpc_listen_unix_or_host
branch
from
0a11e3d to
350ac60
Compare
cl-bvl
force-pushed
the
feature/grpc_listen_unix_or_host
branch
from
350ac60 to
b707e20
Compare
|
a) This branch is clearly behind because both Mark's and Carmine's code is already in the tree and has been for a couple of days. Please rebase to latest master and force push. |
cl-bvl
force-pushed
the
feature/grpc_listen_unix_or_host
branch
from
a128372 to
7ebb5df
Compare
This update lets you specify the network interface for gRPC. For example, using 127.0.0.1 restricts gRPC access to the local machine, enhancing security since gRPC is not publicly exposed. For backward compatibility, the default remains 0.0.0.0. Signed-off-by: Vladimir Buyanov <[email protected]>
cl-bvl
force-pushed
the
feature/grpc_listen_unix_or_host
branch
from
7ebb5df to
45e10c7
Compare
|
Thanks for comments, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please excuse any potential bugs, as I'm not a C++ developer. This update adds the ability to specify the gRPC listening host. Listening on 0.0.0.0 by default is not secure and could lead to significant security breaches due to firewall misconfigurations.
Rest assured, the default behavior remains unchanged for existing users.