Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: Send a correct size of ctx->nh6 for SRv6 SEG6_LOCAL_ACTION_END_DX6 #16876

Conversation

ton31337
Copy link
Member

No description provided.

…_DX6

Fixes: f6e58d2 ("zebra, sharpd: add srv6 End.DX6 support")

Signed-off-by: Donatas Abraitis <[email protected]>
Copy link
Contributor

@cscarpitta cscarpitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donaldsharp
Copy link
Member

Where is this used and should we have had a test case that would have caught this problem?

@ton31337
Copy link
Member Author

Used nowhere except for sharpd, but for sharpd it works fine since it does not touch netlink message yet and displays only ctx->nh6 (correctly).

@donaldsharp donaldsharp merged commit 65609a6 into FRRouting:master Sep 20, 2024
16 checks passed
@ton31337 ton31337 deleted the fix/ZEBRA_SEG6_LOCAL_ACTION_END_DX6_should_put_full_inaddr6 branch September 20, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants