-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dictionary variables and related blocks #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: * "Make a Dictionary" button in the toolbox. * Code for variable creation and name validation for dictionary type. * Related messages in msg/.
7 tasks
tansly
commented
Apr 12, 2019
Now, there is the long work of adding related blocks one by one... Then comes the VM work for their execution at FBDY/bb-vm#51. |
At this point it seems like a good idea to work on FBDY/bb-vm#51 in parallel to this. At least testing the add/get blocks would be nice. |
tansly
commented
Apr 19, 2019
tansly
commented
Apr 19, 2019
* Gives a warning when a dict is created: `Ignoring non-existent input VALUE in block data_for_each_key_in_dict`. At least it doesn't crash.
tansly
changed the title
[WIP] Add dictionary variables and related blocks
Add dictionary variables and related blocks
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also FBDY/bb-vm#50.
TODO:
bb-blocks/core/data_category.js
Lines 103 to 116 in 9042160
Determine which of these operations are applicable to dictionaries and implement the ones which are. -> Implemented the ones that I think are suitable.
bb-blocks/blocks_vertical/data.js
Lines 736 to 740 in 9042160
I vaguely remember testing this stuff but I'm not sure. Remove the comments when sure.
for key in dict
block?for key in dict
block, fix the non-existent field warning -- will deal with this later