Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions for MotorGo Plink, Mini, Axis #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SwapnilPande
Copy link

@SwapnilPande SwapnilPande commented Jan 13, 2025

This PR contains the latest board definitions for the Plink, Mini, and Core. The merge checklists are listed below for each board.

Plink

  • Install the new board definitions
  • Run the main program in this repository to check I2C, LED, and serial
  • Run the example spin_motors example from the driver to verify that motors and encoders work as expected
  • Connect the Pihat compatible boards to a Pi and try communicating over SPI with the Pi
  • Confirm the voltage and current limits for the drivers is correct
  • Confirm that all motor driver pins are set low on boot

Mini

  • Install the new board definitions
  • Run the main program in this repository to check I2C, LED, and serial
  • Run the example spin_motors example from the driver to verify that motors and encoders work as expected
  • Connect the Pihat compatible boards to a Pi and try communicating over SPI with the Pi
  • Confirm the voltage and current limits for the drivers is correct
  • Confirm that all motor driver pins are set low on boot

Axis

  • Install the new board definitions
  • Run the main program in this repository to check I2C, LED, and serial
  • Run the example spin_motors example from the driver to verify that motors and encoders work as expected
  • Connect the Pihat compatible boards to a Pi and try communicating over SPI with the Pi
  • Confirm the voltage and current limits for the drivers is correct
  • Confirm that all motor driver pins are set low on boot

Copy link

github-actions bot commented Jan 13, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added definitions for core, mini, and plink":
    • summary looks empty
    • type/action looks empty
  • the commit message "Finalized MotorGo variant files":
    • summary looks empty
    • type/action looks empty
  • the commit message "Renamed boards to match new naming convention":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello SwapnilPande, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against bd05d1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant