Skip to content

Add sessions and speakers. #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 14, 2025
Merged

Add sessions and speakers. #1101

merged 14 commits into from
Apr 14, 2025

Conversation

nikoshell
Copy link
Contributor

@nikoshell nikoshell commented Apr 1, 2025 •
edited by github-actions bot
Loading

🖼️ Preview available 🖼️ : https://ep-website--1101.org.readthedocs.build/

@nikoshell nikoshell requested review from artcz and clytaemnestra April 1, 2025 11:01
@europython-society
Copy link
Member

europython-society commented Apr 1, 2025 •
edited
Loading

Preview available

Key Value
url https://ep2025-speakers.ep-preview.click
last update 2025-04-14T19:47:17.088Z

@nikoshell nikoshell force-pushed the ep2025-speakers branch 2 times, most recently from c5cb722 to 4e142d8 Compare April 1, 2025 20:21
@nikoshell nikoshell added the DO-NOT-MERGE Not ready to be merged yet label Apr 1, 2025
@nikoshell nikoshell marked this pull request as draft April 2, 2025 10:08
@nikoshell nikoshell requested a review from clytaemnestra April 7, 2025 09:06
@nikoshell nikoshell removed the DO-NOT-MERGE Not ready to be merged yet label Apr 7, 2025
@nikoshell nikoshell force-pushed the ep2025-speakers branch 2 times, most recently from 4225543 to 38b0d50 Compare April 7, 2025 09:50
@nikoshell nikoshell changed the title Add speakers. Add sessions and speakers. Apr 7, 2025
@nikoshell nikoshell mentioned this pull request Apr 7, 2025
Closed
clytaemnestra
clytaemnestra reviewed Apr 7, 2025
View reviewed changes
@egeakman egeakman added the DO-NOT-MERGE Not ready to be merged yet label Apr 7, 2025
@egeakman
Copy link
Member

egeakman commented Apr 7, 2025

Adding do-not-merge for now. We can remove it once we're using the actual api.

@egeakman
Copy link
Member

egeakman commented Apr 7, 2025

image

image

@nikoshell
Copy link
Contributor Author

Adding do-not-merge for now. We can remove it once we're using the actual api.

Sure we can keep it. Keep in mind that it's still draft, many things are in progress.

@nikoshell nikoshell force-pushed the ep2025-speakers branch 5 times, most recently from feef3e6 to 7954c4a Compare April 11, 2025 13:48
@nikoshell
Copy link
Contributor Author

I think that we can close also this ticket with the PR.
Close #1086

@nikoshell nikoshell requested a review from clytaemnestra April 12, 2025 16:51
egeakman
egeakman reviewed Apr 13, 2025
View reviewed changes
Copy link
Member

@egeakman egeakman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikoshell Looks good overall! Is there a reason why we changed entry.slug to entry.id?

Also, can you update the session page to not show Room and Start for now? They are not finalized yet.

@egeakman egeakman mentioned this pull request Apr 13, 2025
Merged
egeakman and others added 2 commits April 13, 2025 20:12
@nikoshell
Copy link
Contributor Author

@nikoshell Looks good overall! Is there a reason why we changed entry.slug to entry.id?

Also, can you update the session page to not show Room and Start for now? They are not finalized yet.

The file() loader creates entries from a single file that contains an array of objects with a unique id field.
I will think about it. We should have ids like 39LFME and slugs like they are now.

@egeakman
Copy link
Member

egeakman commented Apr 13, 2025 •
edited
Loading

@nikoshell Looks good overall! Is there a reason why we changed entry.slug to entry.id?
Also, can you update the session page to not show Room and Start for now? They are not finalized yet.

The file() loader creates entries from a single file that contains an array of objects with a unique id field. I will think about it. We should have ids like 39LFME and slugs like they are now.

My bad, I mixed code and slug. I meant to say id == code I am a bit sleep deprived, need to think about this a bit more :D

@egeakman egeakman mentioned this pull request Apr 14, 2025
Open
@egeakman egeakman removed the DO-NOT-MERGE Not ready to be merged yet label Apr 14, 2025
@egeakman
Copy link
Member

Removing DO-NOT-MERGE since we are using the API endpoints now.

clytaemnestra
clytaemnestra approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

hypha
hypha reviewed Apr 14, 2025
View reviewed changes
hypha
hypha approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor things, none of which should block the merge. Thanks so much for working on this!

@clytaemnestra clytaemnestra mentioned this pull request Apr 14, 2025
Open
@nikoshell nikoshell merged commit 425a1b8 into ep2025 Apr 14, 2025
3 checks passed
@nikoshell nikoshell deleted the ep2025-speakers branch April 14, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clytaemnestra clytaemnestra clytaemnestra approved these changes

@hugovk hugovk hugovk approved these changes

@hypha hypha hypha approved these changes

@artcz artcz Awaiting requested review from artcz

@egeakman egeakman Awaiting requested review from egeakman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikoshell @europython-society @egeakman @hugovk @hypha @clytaemnestra