Skip to content

Subscribe for updates section #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 11, 2025
Merged

Subscribe for updates section #1070

merged 31 commits into from
Apr 11, 2025

Conversation

clytaemnestra
Copy link
Contributor

@clytaemnestra clytaemnestra commented Mar 26, 2025

Changelog

  • added a section with links to our socials and a newsletter signup
  • regarding spam protection: Mailgun starts returning 429 after 5 requests from the same IP, so I guess there's nothing else on our side needed
  • made footer smaller and removed the social media icons from it as they're in the section above

Layout tests

4k

image

Phone

image
image


🖼️ Preview available 🖼️ : https://ep-website--1070.org.readthedocs.build/

@clytaemnestra clytaemnestra changed the title Subscribe for updates section Draft: Subscribe for updates section Mar 26, 2025
@clytaemnestra clytaemnestra changed the title Draft: Subscribe for updates section Subscribe for updates section Mar 26, 2025
@clytaemnestra clytaemnestra marked this pull request as draft March 26, 2025 17:26
@clytaemnestra clytaemnestra force-pushed the ep2025-social-subscribe branch from 6e129f3 to 9385918 Compare March 26, 2025 17:36
@europython-society
Copy link
Member

europython-society commented Mar 26, 2025

Preview available

Key Value
url https://ep2025-social-subscribe.ep-preview.click
last update 2025-04-11T19:15:53.511Z

@clytaemnestra clytaemnestra requested a review from egeakman March 26, 2025 19:56
@clytaemnestra clytaemnestra marked this pull request as ready for review March 26, 2025 19:56
@egeakman egeakman requested a review from Copilot March 26, 2025 20:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src/components/footer.astro: Language not supported
  • src/components/social/SocialSubscribe.astro: Language not supported
  • src/pages/index.astro: Language not supported

Base automatically changed from ep2025-hero to ep2025 March 27, 2025 09:51
@hypha
Copy link
Contributor

hypha commented Mar 27, 2025

Feels like the social buttons are in reverse order. Don't you want to put LinkedIn first and X last?

@clytaemnestra
Copy link
Contributor Author

Feels like the social buttons are in reverse order. Don't you want to put LinkedIn first and X last?

Thanks for the suggestion, swapped ✅

Copy link
Contributor

@nikoshell nikoshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is ok.
Should we prepare common solution for icons before we will use it every where?
Should we introduce right now non static sections without proper api configs and security standards.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge footer links corresponds to all previous years. If we are not introducing new design I will stay with big one.

@clytaemnestra clytaemnestra added the DO-NOT-MERGE Not ready to be merged yet label Mar 28, 2025
@clytaemnestra clytaemnestra marked this pull request as draft March 28, 2025 07:12
@clytaemnestra
Copy link
Contributor Author

We agreed with @nikoshell to keep the PR as a reference, but first to implement security standards and then to reimplement this section.

@nikoshell nikoshell removed the DO-NOT-MERGE Not ready to be merged yet label Apr 11, 2025
@nikoshell nikoshell marked this pull request as ready for review April 11, 2025 15:39
Copy link
Contributor

@artcz artcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artcz artcz merged commit 5295ca6 into ep2025 Apr 11, 2025
3 checks passed
@artcz artcz deleted the ep2025-social-subscribe branch April 11, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants