Use version of canvas-action from package set
#2
Conversation
| @@ -1,37 +1,45 @@ | |||
| { | |||
| "name": "purescript-grid-reactors", | |||
There was a problem hiding this comment.
The churn in this file is due to spago bump-version replacing the bower.json.
|
|
||
| in upstream | ||
| with canvas-action = |
There was a problem hiding this comment.
We no longer need this override as we can use the version of canvas-action from the package set.
The only difference between the version in the package set and the version that was previously referenced is a README change: artemisSystem/purescript-canvas-action@v7.0.0...43de19e
|
Thank you, much appreciated! |
No problem! Would you mind publishing a new version so I can update this in the package set? |
|
No at all. First, I'll need to remind myself how to do that ;-) I'll also update the npm deps to fix some (perceived) vulnerabilities when I'm at it. |
|
By the way, is this post on Pursuit a good checklist to follow when publishing packages? |
While I think that page has all the necessary information, I think this Discourse post might be a bit easier to follow. |
|
Thank you, good find. Anyway, everything's done. Shall I update the package set, or will you do it? |
I'll be able to take care of it, unless you're really dying to do it 😄 |
@Eugleo Would you mind pushing the |
|
Not really, I'll gladly let you do the honors :-D You'll be adding it to the next coming package set, I assume? Meaning, if I want to use the newest version now, I'll have to refer to it by the commit hash for the time being, correct? |
Correct, it would be in the next version of the package set (although we're usually pretty good about putting those out regularly; shouldn't be more than a couple days). Until then you would have to add it as an addition to your |
|
Ok. I just pushed the tag. |
Thank you! Here's the PR to add the new version to the package set: purescript/package-sets#1033 |
This PR makes it so
grid-reactorsdepends on the version ofcanvas-actionfrom the package set instead of an arbitrary Git tag.As part of this, we also had to upgrade to a newer version of the package set.
Motivation
grid-reactorsis currently in the PureScript package set and will need to have these dependency issues resolved in order to remain in the package set after the move to the new PureScript registry.See purescript/registry#250 for more details.