Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub-common): site collections not hidden properly #1827

Merged
merged 5 commits into from
Mar 11, 2025

Conversation

abp6318
Copy link
Contributor

@abp6318 abp6318 commented Mar 6, 2025

affects: @esri/hub-common

  1. Description: related opendata-ui PR: https://github.com/ArcGIS/opendata-ui/pull/14552

  2. Closes Issues: https://devtopia.esri.com/dc/hub/issues/12610

opendata-ui PR: https://github.com/ArcGIS/opendata-ui/pull/14552
Testing site: https://rochester-moose-qa-pre-a-hub.hubqa.arcgis.com/workspace/sites/8e67c41951804ef9965e290b3d83c182/details?uiVersion=PR-14552

  1. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  2. used semantic commit messages

  3. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  4. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

…pulating the display config has

affects: @esri/hub-common
@abp6318 abp6318 added the bug Something isn't working label Mar 6, 2025
@abp6318 abp6318 self-assigned this Mar 6, 2025
Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Mar 10, 2025
@abp6318 abp6318 requested a review from sonofflynn89 March 10, 2025 18:20
Copy link
Contributor

@sonofflynn89 sonofflynn89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Aaron!

@github-actions github-actions bot removed the Stale Stale issue - update or it will be closed label Mar 11, 2025
@abp6318 abp6318 merged commit c0a0bb8 into master Mar 11, 2025
5 checks passed
@abp6318 abp6318 deleted the b/12610-respect-hidden-site-collections branch March 11, 2025 20:18
esri-dcdev-2 pushed a commit that referenced this pull request Mar 11, 2025
## @esri/hub-common [15.41.2](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-11)

### Bug Fixes

* **hub-common:** site collections not hidden properly ([#1827](#1827)) ([c0a0bb8](c0a0bb8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants