Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub-common): site entity only displays slug on enterprise #1817

Merged

Conversation

juliannaeapicella
Copy link
Contributor

  1. Description:

  2. Instructions for testing:

  3. Closes Issues: #12435

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

Copy link
Contributor

@rweber-esri rweber-esri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified using ?uiVersion=PR-14513 that the slug field no longer displays in the site entity details workspace pane on Hub.

@juliannaeapicella juliannaeapicella merged commit 2090f98 into master Feb 27, 2025
5 checks passed
@juliannaeapicella juliannaeapicella deleted the 11634/slug-field-should-not-display-on-site-entity branch February 27, 2025 16:53
esri-dcdev-2 pushed a commit that referenced this pull request Feb 27, 2025
## @esri/hub-common [15.38.2](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-27)

### Bug Fixes

* **hub-common:** site entity only displays slug on enterprise ([#1817](#1817)) ([2090f98](2090f98))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants