feat(hub-discussions): remove all fns, types & tests from hub-discuss… #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rweber-esri
requested review from
dbouwman,
velveetachef and
juliannaeapicella
4 tasks
rweber-esri
force-pushed
the
t/move-contents-of-hub-discussions-to-hub-common
branch
from
e61638a to
dde01b6
Compare
|
There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label. |
rweber-esri
force-pushed
the
t/move-contents-of-hub-discussions-to-hub-common
branch
from
89d374a to
a1ec6a0
Compare
rweber-esri
force-pushed
the
t/move-contents-of-hub-discussions-to-hub-common
branch
3 times, most recently
from
8a57e01 to
bb5100c
Compare
Base automatically changed from
t/move-contents-of-hub-discussions-to-hub-common
to
master
February 26, 2025 21:46
…@esri/arcgis-rest-portal in dis affects: @esri/hub-common ISSUES CLOSED: 12495
…ions & re-export those artifact affects: @esri/hub-discussions ISSUES CLOSED: 12495
…moved to hub-common, flatten re affects: @esri/hub-discussions ISSUES CLOSED: 12495
affects: @esri/hub-discussions ISSUES CLOSED: 12495
…n version affects: @esri/hub-discussions ISSUES CLOSED: 12495
affects: @esri/hub-discussions ISSUES CLOSED: 12495
rweber-esri
force-pushed
the
t/remove-src-types-and-tests-from-hub-discussions
branch
from
beb7588 to
067a9d3
Compare
…during rebase affects: @esri/hub-common ISSUES CLOSED: 12495
This reverts commit 067a9d3.
rweber-esri
deleted the
t/remove-src-types-and-tests-from-hub-discussions
branch
esri-dcdev-2
pushed a commit
that referenced
this pull request
Feb 27, 2025
# @esri/hub-discussions [29.7.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-02-27) ### Features * **hub-discussions:** remove all fns, types & tests from hub-discuss… ([#1811](#1811)) ([58c1b1d](58c1b1d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions & re-export those artifact
affects: @esri/hub-discussions
ISSUES CLOSED: 12495
This is the second of 2 PRs to move all remaining fns, types, etc, from the
hub-discussionspackage intohub-common.This PR:
hub-discussionshub-discussionsfor artifacts moved intohub-commonhub-discussions(with the exception of the test created in 3 below)hub-discussionspeer dependencies (TODO once PR-1810 merges/publishes)The previous PR:
hub-discussionsintohub-commonhub-discussionsis now exported fromhub-commonhub-discussionsto verify all currently exported fns, constants, etc.Once these 2 PRs are merged/published, we can update any imports from
hub-discussionstohub-commonand removehub-discussionsfrom the opendata-ui package dependencies.Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependenciesas needed. CRITICAL our automated release system can not be counted on to updatepeerDependenciesso we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.