fix: more tests

Author: abp6318

packages/common/src/sites/_internal/applyDefaultCollectionMigration.ts

@@ -89,7 +89,7 @@ export function applyDefaultCollectionMigration(model: IModel): IModel {
         searchCategoryToCollection[searchCategory.key as SearchCategories];
       const collection = baseCollectionMap[collectionKey];
       collection.label = searchCategory.overrideText || null;
-      collection.displayConfig.hidden = searchCategory.hidden;
+      collection.displayConfig.hidden = !!searchCategory.hidden;
       return collection;
     });
 

packages/common/test/sites/_internal/applyDefaultCollectionMigration.test.ts

@@ -47,13 +47,7 @@ describe("applyDefaultCollectionMigration", () => {
     const hiddenStatuses = result.data.catalog.collections.map(
       (c: IHubCollection) => c.displayConfig?.hidden
     );
-    expect(hiddenStatuses).toEqual([
-      undefined,
-      true,
-      undefined,
-      undefined,
-      undefined,
-    ]);
+    expect(hiddenStatuses).toEqual([false, true, false, false, false]);
   });
 
   it("Reorders, re-labels, and hides default collections when search categories are configured", () => {
@@ -97,7 +91,7 @@ describe("applyDefaultCollectionMigration", () => {
     const hiddenStatuses = result.data.catalog.collections.map(
       (c: IHubCollection) => c.displayConfig.hidden
     );
-    expect(hiddenStatuses).toEqual([undefined, undefined, true, false, false]);
+    expect(hiddenStatuses).toEqual([false, false, true, false, false]);
   });
 
   it("Handles when a site has the 'initiatives' search category saved", () => {
@@ -123,7 +117,7 @@ describe("applyDefaultCollectionMigration", () => {
     const hiddenStatuses = result.data.catalog.collections.map(
       (c: IHubCollection) => c.displayConfig.hidden
     );
-    expect(hiddenStatuses).toEqual([undefined, true]);
+    expect(hiddenStatuses).toEqual([false, true]);
   });
 
   it("Omits unsupported search categories, like an explicit 'all' or events", () => {
@@ -152,6 +146,6 @@ describe("applyDefaultCollectionMigration", () => {
     const hiddenStatuses = result.data.catalog.collections.map(
       (c: IHubCollection) => c.displayConfig.hidden
     );
-    expect(hiddenStatuses).toEqual([undefined]);
+    expect(hiddenStatuses).toEqual([false]);
   });
 });