fix: tets

Author: abp6318

package-lock.json

@@ -45,7 +45,7 @@ export function reflectCollectionsToSearchCategories(model: IModel) {
       const searchCategoryKey =
         collectionToSearchCategory[c.key as WellKnownCollection];
       const updated: any = {
-        hidden: c.displayConfig?.hidden,
+        hidden: !!c.displayConfig?.hidden,
         key: searchCategoryKey,
         queryParams: {
           collection: searchCategoryToQueryParam[searchCategoryKey],

packages/common/src/sites/_internal/reflectCollectionsToSearchCategories.ts

@@ -55,6 +55,17 @@ describe("reflectCollectionsToSearchCategories", () => {
           filters: [],
         },
       } as IHubCollection,
+      {
+        label: null,
+        key: "appAndMap",
+        targetEntity: "item",
+        // intentionally leaving out displayConfig.hidden for branch coverage
+        scope: {
+          targetEntity: "item",
+          collection: "appAndMap",
+          filters: [],
+        },
+      } as IHubCollection,
     ];
 
     const result = reflectCollectionsToSearchCategories(site);
@@ -73,6 +84,13 @@ describe("reflectCollectionsToSearchCategories", () => {
           collection: "Document",
         },
       },
+      {
+        key: SearchCategories.APPS_AND_MAPS,
+        hidden: false,
+        queryParams: {
+          collection: "App,Map",
+        },
+      },
     ]);
   });
   it("handles re-labeled collections", () => {

packages/common/test/sites/_internal/reflectCollectionsToSearchCategories.test.ts

@@ -15,19 +15,19 @@ describe("getCatalogFromSiteModel", () => {
 
     expect(chk.title).toBe("Default Site Catalog");
     expect(chk.scopes).toBeDefined();
-    expect(chk.scopes?.item?.filters.length).toBe(1);
-    expect(chk.scopes?.item?.filters[0].predicates[0].group).toEqual([
+    expect(chk.scopes.item.filters.length).toBe(1);
+    expect(chk.scopes.item.filters[0].predicates[0].group).toEqual([
       "00c",
       "00d",
     ]);
-    expect(chk.scopes?.event?.filters.length).toBe(1);
-    expect(chk.scopes?.event?.filters[0].predicates[0].group).toEqual([
+    expect(chk.scopes.event.filters.length).toBe(1);
+    expect(chk.scopes.event.filters[0].predicates[0].group).toEqual([
       "00c",
       "00d",
     ]);
 
     // check for collections
-    expect(chk.collections?.map((c) => c.key)).toEqual([
+    expect(chk.collections.map((c) => c.key)).toEqual([
       "all",
       "site",
       "dataset",