Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooltip): no longer use capture events. #9839

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

refactor(tooltip): no longer use capture events. #9839

wants to merge 14 commits into from

Conversation

driskull
Copy link
Member

@driskull driskull commented Jul 23, 2024 •
edited
Loading

Related Issue: None

Summary

  • Update TooltipManager to no longer use capture events.
  • preventDefault() on escape key pressed from a referenceElement or active tooltip.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jul 23, 2024
@driskull driskull marked this pull request as ready for review July 23, 2024 17:55
@driskull driskull requested a review from jcfranco July 23, 2024 17:55
@driskull driskull mentioned this pull request Jul 23, 2024
Closed
jcfranco
jcfranco approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Can we make sure to land this after our August (R3) release?

packages/calcite-components/src/components/tooltip/tooltip.e2e.ts Outdated Show resolved Hide resolved
@driskull
Copy link
Member Author

Can we make sure to land this after our August (R3) release?

@jcfranco can we land this in the July release?

@jcfranco
Copy link
Member

I'd like to hold off until September to prevent teams encountering issues similar to #9013 near the R3 release.

@driskull
Copy link
Member Author

Ok sounds good

@driskull
Merge branch 'dris0000/tooltip-focus-click-fix' into dris0000/tooltip…
9e7abf3 
…-remove-capture-event

# Conflicts:
#	packages/calcite-components/src/components/tooltip/TooltipManager.ts
@driskull
Merge branch 'dev' into dris0000/tooltip-remove-capture-event
6dcd64d 
# Conflicts:
#	packages/calcite-components/src/components/tooltip/TooltipManager.ts
#	packages/calcite-components/src/components/tooltip/tooltip.e2e.ts
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 15, 2024
@jcfranco
Copy link
Member

I'd like to hold off until September to prevent teams encountering issues similar to #9013 near the R3 release.

Belated apologies, I meant to say "hold off until October or at least after September" (post-R3). I'll adjust the milestone.

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Aug 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
refactor Issues tied to code that needs to be significantly reworked. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco