-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(action-bar, action-pad)!: Do not modify text-enabled on slotted actions unless expanded is toggled #9554
base: dev
Are you sure you want to change the base?
Conversation
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
# Conflicts: # packages/calcite-components/src/components/action-bar/action-bar.stories.ts # packages/calcite-components/src/components/action-pad/action-pad.stories.ts
# Conflicts: # packages/calcite-components/src/components/action-bar/action-bar.tsx # packages/calcite-components/src/components/action-pad/action-pad.tsx
Related Issue: #8886
BREAKING CHANGE: When slotting actions within the component you must now set
textEnabled
on them if necessary.Summary
action-bar
andaction-pad
to only change child actionstextEnabled
property when the component is expanded or collapsed.textEnabled
on children.textEnabled