refactor: simplify reflected attribute accesses #10356
Open
+8
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
maxpatiiuk
commented
Sep 19, 2024
| @@ -764,10 +761,6 @@ export class Dialog | |||
| } | |||
| } | |||
|
|
|||
| private setContainerEl = (el: HTMLDivElement): void => { | |||
There was a problem hiding this comment.
Never read, thus removed
| @@ -774,9 +774,9 @@ export class InputDatePicker | |||
|
|
|||
| @State() private localeData: DateLocaleData; | |||
|
|
|||
| private startInput: HTMLCalciteInputElement; | |||
| private startInput: HTMLCalciteInputTextElement; | |||
There was a problem hiding this comment.
This was causing a type error in Lumina - the ref is assigned to calcite-input-text, but the type here was calcite-input.
packages/calcite-components/src/components/input-number/input-number.tsx
Outdated
Show resolved
Hide resolved
maxpatiiuk
commented
Sep 19, 2024
| @@ -146,8 +146,6 @@ export class Tooltip implements FloatingUIComponent, OpenCloseComponent { | |||
|
|
|||
| guid = `calcite-tooltip-${guid()}`; | |||
|
|
|||
| hasLoaded = false; | |||
maxpatiiuk
commented
Sep 19, 2024
| @@ -228,7 +228,7 @@ export class CalciteMenu implements LocalizedComponent, T9nComponent, LoadableCo | |||
| } | |||
|
|
|||
| private getEffectiveRole(): string { | |||
| return this.el.getAttribute("role") || "menubar"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactor - some HTML attributes are reflected to properties.
Thus, we can access properties instead of calling getAttribute/hasAttribute.
Properties are also more type-safe (where as getAttribute string parameter does not have type-checking)
And other minor changes.