feat(carousel): Improve support for high item counts #10315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macandcheese
added
the
pr ready for visual snapshots
github-actions
bot
added
the
enhancement
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
macandcheese
requested review from
jcfranco,
driskull,
SkyeSeitz and
ashetland
driskull
requested changes
Sep 16, 2024
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
6 tasks
macandcheese
added
pr ready for visual snapshots
jcfranco
approved these changes
Sep 17, 2024
packages/calcite-components/src/components/carousel/carousel.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/resources.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/carousel/carousel.tsx
Outdated
Show resolved
Hide resolved
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
macandcheese
deleted the
macandcheese/9121-carousel-support-limiting-pagination
branch
benelan
added a commit
that referenced
this pull request
Sep 19, 2024
* origin/dev: fix(shell): fix z-index of slotted popover elements (#10325) fix(dialog): only prevent default on escape key when escapeDisabled is true (#10336) chore: release next feat(carousel): Improve support for high item counts (#10315) feat: add content inline right (#10338) fix: correct non-standard filled icon names (#10309) fix(panel): initially closed panel should be hidden (#10308) chore(linting): automate tracking of custom Sass functions for stylelint (#10313) chore: tidy up demo pages (#10314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9121
Adds support for better display of high Carousel Item counts by automatically adjusting the number shown as container width changes.
Screen.Recording.2024-09-14.at.5.48.32.PM.mov
Summary
This follows the pattern found in Pagination, as the behavior is quite similar, but there are a few differences in Carousel to support the "rotation effect" of the "dots".