Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): add component tokens #10270

Closed
wants to merge 4 commits into from

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Sep 11, 2024

Related Issue: #7180

Summary

Add tabs component tokens.

--calcite-tabs-background-color: The background color of the component.
--calcite-tabs-border-color: The border color of the component.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Sep 11, 2024
@Elijbet Elijbet marked this pull request as ready for review September 11, 2024 19:42
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done in conjunction with tabs, tab-title, tab-nav. There is a larger design pattern that these components need to coordinate. You can't just change the border color in tabs and not tab-title.

@jcfranco jcfranco marked this pull request as draft September 11, 2024 23:29
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Sep 21, 2024
@jcfranco
Copy link
Member

Closing in favor of #10532. Thanks for taking an early stab a this, @Elijbet!

@jcfranco jcfranco closed this Oct 17, 2024
@jcfranco jcfranco deleted the elijbet/7180-add-tabs-design-tokens branch October 17, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants