Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte accuracy/difficulty dialog #287

Merged
merged 95 commits into from
Aug 31, 2021
Merged

Svelte accuracy/difficulty dialog #287

merged 95 commits into from
Aug 31, 2021

Commits on Jul 13, 2021

  1. rewrite accdiff dialog as a FormApplication, so it has a data model

    @SohumB
    SohumB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    0be56ca View commit details
    Browse the repository at this point in the history

  2. not sure why this collapse was there before 

    the only practical upshot of this collapse is that sometimes tech attacks
wouldn't expand to show some of the attack rolls. I've adjusted it to match
the regular attack rolls
    @SohumB
    SohumB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    28ca3a2 View commit details
    Browse the repository at this point in the history

  3. factor out common code between tech and weapon attacks 

    + take the opportunity to de-serialise operations a tiny bit
    @SohumB
    SohumB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    0542ac8 View commit details
    Browse the repository at this point in the history

  4. implement multi-target acc/diff and cover in the acc_diff form 

    subtasks:
* separate out {{std-cover-input}} and {{accdiff-total-display}}
* rejigger accdiff's data model (again) (we use get total() functions now)
* messy UI work for the multi-target section of the acc_diff form
    @SohumB
    SohumB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    f46b876 View commit details
    Browse the repository at this point in the history

  5. split out the reactive form logic into an abstract class

    @SohumB
    SohumB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    914676e View commit details
    Browse the repository at this point in the history

  6. simplify a bit of promise logic

    @SohumB
    SohumB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    591ac37 View commit details
    Browse the repository at this point in the history

  7. restructure attack macros to allow reroll accdiff data

    @SohumB
    SohumB committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    29b5f86 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. give the accdiff code the tokens, rather than just the actors

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    77c26bb View commit details
    Browse the repository at this point in the history

  2. restructure AccDiffData to have a coherent serialization story

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    0d1d909 View commit details
    Browse the repository at this point in the history

  3. encode a reroll macro into attack chat cards

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    0d79b68 View commit details
    Browse the repository at this point in the history

  4. ev.target is the innermost clicked element, not the .chat-button

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    14f88e1 View commit details
    Browse the repository at this point in the history

  5. maybe a small animation to let people know it's clickable?

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    42cadb1 View commit details
    Browse the repository at this point in the history

  6. three columns for the multitarget row

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    d543c06 View commit details
    Browse the repository at this point in the history

  7. rewrite encoded macros to be restricted to a whitelist

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ed73099 View commit details
    Browse the repository at this point in the history

  8. bugfix: structure damage macro was broken

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    99800d4 View commit details
    Browse the repository at this point in the history

  9. the 1-target case looks nicer without the duplicated UI

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    a6db06e View commit details
    Browse the repository at this point in the history

  10. woops — drop handler also depends on the old LancerMacroData defn

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    fd66eff View commit details
    Browse the repository at this point in the history

  11. marking this as lancer-macro does nothing right now, but in prep 

    if/when we choose to extend lancer-actor-sheet's EncodedMacroHandler
to the whole app, we will be _ready_
    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    5dfcdd3 View commit details
    Browse the repository at this point in the history

  12. restructure accdiff datamodel: separate weapon & default base target

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6c21fc1 View commit details
    Browse the repository at this point in the history

  13. let's be more explicit on the one-target window, using it as a teach

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    998b7c2 View commit details
    Browse the repository at this point in the history

  14. bugfix: target is a LancerTokenDocument here, not a LancerToken

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    53dd2bb View commit details
    Browse the repository at this point in the history

  15. consume lockon on the data model/rolling side, w/ 1-target UI

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    c9a4b5f View commit details
    Browse the repository at this point in the history

  16. simplify {{std-cover-input}} a bit

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    04ebc7c View commit details
    Browse the repository at this point in the history

  17. kill some of the duplication in acc_diff.hbs with an inline partial

    @SohumB
    SohumB committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7400b7b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. UI for lockon on the multi-target accdiff modal

    @SohumB
    SohumB committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    24b082a View commit details
    Browse the repository at this point in the history

  2. hey let's actually load in persisted consumeLockOns, huh?

    @SohumB
    SohumB committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    13a9522 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. move to io-ts serialization, in preparation for plugins

    @SohumB
    SohumB committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    1bcc5de View commit details
    Browse the repository at this point in the history

  2. plugin framework, and Invisibility as a plugin 

    we have basic checkbox UI for plugins, but not in the multi-target version of accdiff yet
    @SohumB
    SohumB committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    1cb4658 View commit details
    Browse the repository at this point in the history

  3. some comments and cleanup in invisibility / the plugin interface

    @SohumB
    SohumB committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    afe309f View commit details
    Browse the repository at this point in the history

  4. making it the default export is nicer

    @SohumB
    SohumB committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    16391f2 View commit details
    Browse the repository at this point in the history

  5. let plugins see the item that started the roll

    @SohumB
    SohumB committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    a024931 View commit details
    Browse the repository at this point in the history

  6. allow plugins to have no ui

    @SohumB
    SohumB committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    a78b39c View commit details
    Browse the repository at this point in the history

  7. basic Spotter plugin with no ui and a hacky adjacency calculation

    @SohumB
    SohumB committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    682e3df View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. nicer roll rendering: {roll} doesn't collapse the roll, (roll) does

    @SohumB
    SohumB committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    aed6c72 View commit details
    Browse the repository at this point in the history

  2. add spaces to the bonus for consistency

    @SohumB
    SohumB committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    6913f2d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. did you know foundry just has special syntax for coins

    @SohumB
    SohumB committed Jul 18, 2021
    Configuration menu
    Copy the full SHA
    a0a9b4c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. some css fixes for the accdiff window

    @SohumB
    SohumB committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    85253fa View commit details
    Browse the repository at this point in the history

  2. dropdown for plugin UIs in the multi-target dialog

    @SohumB
    SohumB committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    03dd7dd View commit details
    Browse the repository at this point in the history

  3. use non-breaking spaces inside labels

    @SohumB
    SohumB committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    86d7f6a View commit details
    Browse the repository at this point in the history

  4. give spotter a UI (though no override)

    @SohumB
    SohumB committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    5947e10 View commit details
    Browse the repository at this point in the history

  5. use opacity to mark disabled, instead of color 

    this lets us differentiate disabled+checked from disabled+unchecked
    @SohumB
    SohumB committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    b0665d1 View commit details
    Browse the repository at this point in the history

  6. implement impaired in the core (not as a plugin)

    @SohumB
    SohumB committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    0272746 View commit details
    Browse the repository at this point in the history

  7. implement rerolls for tech attacks 

    on all three entrypoints:
* prepareActivationMacro
* prepareStatMacro
* prepareTechMacro
    @SohumB
    SohumB committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    dbb52bc View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Merge branch 'dev-1.0' into acc-diff-updates

    @SohumB
    SohumB committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    02013f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Merge branch 'dev-1.0' into acc-diff-updates

    @SohumB
    SohumB committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    5ff4141 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Merge branch 'dev-1.0' into acc-diff-updates

    @SohumB
    SohumB committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    eb13d5e View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Merge branches 'acc-diff-updates' and 'vite-build' into svelte-accdiff

    @SohumB
    SohumB committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    8badeb8 View commit details
    Browse the repository at this point in the history

  2. dynamically import everything under accdiff as needed

    @SohumB
    SohumB committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    62fa8c6 View commit details
    Browse the repository at this point in the history

  3. add svelte to the build

    @SohumB
    SohumB committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    78c23d5 View commit details
    Browse the repository at this point in the history

  4. rewrite accdiff as a svelte component

    @SohumB
    SohumB committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    7569acb View commit details
    Browse the repository at this point in the history

  5. move css into the svelte components, to scope them as possible

    @SohumB
    SohumB committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    5afbf3e View commit details
    Browse the repository at this point in the history

  6. remove the now-extraneous handlebars helpers/templates

    @SohumB
    SohumB committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    e829003 View commit details
    Browse the repository at this point in the history

  7. unnecessarily fancy transitions

    @SohumB
    SohumB committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    8804d64 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. bugfix: actually allow id to be sent in as props

    @SohumB
    SohumB committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    2e00a8c View commit details
    Browse the repository at this point in the history

  2. bugfix: just in case this is a promise

    @SohumB
    SohumB committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    f4180bb View commit details
    Browse the repository at this point in the history

  3. typefix: this is a bit messy, but Component is still better than any

    @SohumB
    SohumB committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    443fc20 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. bugfix: actually this is what svelte understands as dependency arrows

    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    1c0aff3 View commit details
    Browse the repository at this point in the history

  2. typefix: t.InputOf is just unknown

    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    97d5f0c View commit details
    Browse the repository at this point in the history

  3. make hydrate slightly more coherent

    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    f6b6c86 View commit details
    Browse the repository at this point in the history

  4. add AccDiffTarget.fromParams

    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    2af87e8 View commit details
    Browse the repository at this point in the history

  5. clean up svelte-application, provide useful promise methods, support … 

    …intro: true
    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    f4d1686 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev-1.0' into svelte-accdiff

    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    8fffdac View commit details
    Browse the repository at this point in the history

  7. use my version of vite-plugin-checker that supports svelte-check

    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    bbcc834 View commit details
    Browse the repository at this point in the history

  8. first pass at a persistent accdiff sliding window 

    TODO:
* clean up index.ts, there's enough logic in there now that it should be split
* hover-targeting breaks once you click inside the window
* Enter and Esc don't work how you expect them to either inside or outside the window
    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    361f555 View commit details
    Browse the repository at this point in the history

  9. split index.ts into data.ts and form.ts

    @SohumB
    SohumB committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    2ba6746 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. sliding hud windows for accdiff

    @SohumB
    SohumB committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    9d1225b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. make the window popup way way less aggressive

    @SohumB
    SohumB committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    879691b View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. this function should be three separate functions

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    267448e View commit details
    Browse the repository at this point in the history

  2. bugfix: this esc handler was very wrong

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    8712c1b View commit details
    Browse the repository at this point in the history

  3. bugfix: data should be able to flow in and out of these components

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    460b542 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev-1.0' into svelte-accdiff-sliding

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    ab62420 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev-1.0' into svelte-accdiff

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    3a1ddea View commit details
    Browse the repository at this point in the history

  6. tweak the transitions some

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    58347a1 View commit details
    Browse the repository at this point in the history

  7. support cub in findEffect

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    d636d60 View commit details
    Browse the repository at this point in the history

  8. preserve target-specific data as targets are refreshed

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    786cb28 View commit details
    Browse the repository at this point in the history

  9. fade out hudzone on drag/drop

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    c256065 View commit details
    Browse the repository at this point in the history

  10. pull sliding hud to the top, give it a nice drop shadow

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    4db2efd View commit details
    Browse the repository at this point in the history

  11. track impaired even when we don't have a weapon (hase rolls)

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    1afdbd3 View commit details
    Browse the repository at this point in the history

  12. unused import

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    e4b64b3 View commit details
    Browse the repository at this point in the history

  13. make the +acc/+diff buttons look nice both under emu and normal

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    9f5891f View commit details
    Browse the repository at this point in the history

  14. fix total's transitions, and apply a nice little shadow to the card

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    3ae7b41 View commit details
    Browse the repository at this point in the history

  15. situate the target boxes with a box-shadow

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    b224ef1 View commit details
    Browse the repository at this point in the history

  16. style cover nicely with a moving cover selection arrow

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    7c12cfe View commit details
    Browse the repository at this point in the history

  17. remove overflow: hidden from grid-enforcement; it seems unnecessary 

    and breaks this tippy
    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    c57a4af View commit details
    Browse the repository at this point in the history

  18. handle basic attack rerolls initiated by refreshTargeting

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    53ba4ef View commit details
    Browse the repository at this point in the history

  19. the grid rows in accdiff targets needed a larger gap

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    85184a1 View commit details
    Browse the repository at this point in the history

  20. add plugin classes, for styling

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    4cdda1a View commit details
    Browse the repository at this point in the history

  21. invisibility animation

    @SohumB
    SohumB committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    2cc70d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. enable spotter on basic attacks 

    * spotter needs to look at lancerActor
* we need to do _some_ work to get a valid lancerActor on basic attacks
    @SohumB
    SohumB committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    f701c2e View commit details
    Browse the repository at this point in the history

  2. fix spotter crashing on adjacent npcs

    @SohumB
    SohumB committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    9d33819 View commit details
    Browse the repository at this point in the history

  3. swap to mdi-shields for cover iconography

    @SohumB
    SohumB committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    b81c989 View commit details
    Browse the repository at this point in the history

  4. move prepareStructureSecondaryRollMacro into macros.ts

    @SohumB
    SohumB committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    8262e59 View commit details
    Browse the repository at this point in the history

  5. nope, sorry, I'm changing my mind, 12px is the right amount of px

    @SohumB
    SohumB committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    893380a View commit details
    Browse the repository at this point in the history

  6. bugfix: weapon.plugins is an object, not an array

    @SohumB
    SohumB committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    313dea9 View commit details
    Browse the repository at this point in the history

  7. removing css-loader and @mdi/font, both now unused

    @SohumB
    SohumB committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    639f18e View commit details
    Browse the repository at this point in the history