Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

David/add liquidity #1

Merged
merged 6 commits into from
Feb 14, 2025
Merged

David/add liquidity #1

merged 6 commits into from
Feb 14, 2025

Conversation

dberget
Copy link

@dberget dberget commented Feb 14, 2025

No description provided.

@ZeroSums ZeroSums self-assigned this Feb 14, 2025
dberget
dberget commented Feb 14, 2025
View reviewed changes
pages/dao/[symbol]/proposal/components/instructions/Meteora/CreatePosition.tsx
const TOTAL_RANGE_INTERVAL = 10;
minBinId = activeBin.binId - TOTAL_RANGE_INTERVAL;
maxBinId = activeBin.binId + TOTAL_RANGE_INTERVAL;
const TOTAL_RANGE_INTERVAL = 25
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this but not sure if 25 is the best full default either.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally, despise hardcoding values - can you provide any insight, into it's possible to calculate the range interval dynamically - or at the very least, use the .env?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dynamically doesn't really make sense for this particular value, if they select a particular bin range from the uI though then that would be used. This should be the default max bin value which i think is supposed to be 70. i'll test that quick and see. I'll move it to a better labeled value const after that.

@ZeroSums
Copy link

Ready to merge with Main once conversation is completed

TheLazySol
TheLazySol approved these changes Feb 14, 2025
View reviewed changes
Copy link

@TheLazySol TheLazySol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Going to run a test and then merge/

@TheLazySol TheLazySol merged commit 8f2861c into feature/add-liquidity-instruction Feb 14, 2025
@TheLazySol
Copy link

merging and removing your branch :D

@TheLazySol TheLazySol deleted the david/add-liq branch February 14, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroSums ZeroSums ZeroSums left review comments

@TheLazySol TheLazySol TheLazySol approved these changes

Assignees

@ZeroSums ZeroSums

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dberget @ZeroSums @TheLazySol