Exp/bls-multisig-impl #175
Conversation
…validatorConfig and validator structs need to be modified
…o normal struct type
| network_addresses: vector<u8>, | ||
| fullnode_addresses: vector<u8>, | ||
| ) acquires AllowedValidators { | ||
| // Checks the public key is valid to prevent rogue-key attacks. | ||
| let valid_public_key = ed25519::new_validated_public_key_from_bytes(consensus_pubkey); | ||
| assert!(option::is_some(&valid_public_key), error::invalid_argument(EINVALID_PUBLIC_KEY)); | ||
|
|
||
| //DO WE HAVE TO ADD CHECK FOR BLS KEY TOO? I AM NOT SURE. |
There was a problem hiding this comment.
Yes, we will need to ensure that the bytes comprise a valid BLS key.
There was a problem hiding this comment.
for this verification, we required native function in move VM.
| @@ -1900,8 +1904,10 @@ module supra_framework::stake { | |||
| account::create_account_for_test(validator_address); | |||
| }; | |||
|
|
|||
| let bls_pk_bytes = vector[]; | |||
There was a problem hiding this comment.
If we are calling this function anywhere, then this could be causing deserialization problems. The value needs to be initialized.
| use std::fmt; | ||
| use blsttc::{SecretKey, PublicKeyG2}; | ||
|
|
||
| /// An Ed25519 private key |
There was a problem hiding this comment.
Why does this still say Ed25519? Several places in this file seem to, actually. Have you tested this code?
There was a problem hiding this comment.
actually. i forked it from ed15519 for keeping consistent file structures and similar methods and then changes functionalities inside, so might be left off to update content in documented code lines. will update it while finishing off.
…ield for bls key.
draft PR