Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DMS] March release branch, release Thursday 27 #6603
[DMS] March release branch, release Thursday 27 #6603
Changes from all commits
910235c
03446eb
19a6240
00079dc
bbbd1b5
da9b04e
dd29add
2b17183
c942590
54af3ef
a424492
c939f91
a2a8969
9d46c84
d720621
d550baa
c37e762
c35b0da
1995809
4a341d6
b42db55
58bc8e1
2e76fa0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a setting for something that is in a user's environment or in the HCP deployment environment? If the latter, is this a value that a user of the HCP will know or will they have to get this from an administrator? This should be clearer. And, if it is something that is specified in the HCP configuration, the admin's, who may not have set up the HCP, will need to know how find it.
@jperozoa @yidian1997 Settings like this and the
RW_SERVICE_HOST
have me wondering if there is a way for a user to have an environment specific run-cdcreader.sh and run-cdcwriter.sh files generated for them that would populate some of these values for them based on the HCP deployment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those access key related values should get from administrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who can we ask more about this? If an admin needs to provide this information, where does he/she get it?
Do they check in their AWS console? Is there a command they can run to fetch this and all subsequent values that start with
AWS_
? Or maybe all these values are related to something established during the installation of the HCP?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, in a conversation I had with @jperozoa earlier today, it's my understanding that these S3 related settings are only required if you have large rows in your source database that needs to be migrated. As I understand it, transporter can actually migrate the large rows, but setting these variables will improve performance of migrating large rows. If they are optional, we should note that they are optional but recommended and provide their purpose/benefit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question here as I did in my comment under to the
AWS_ACCESS_KEY_ID
setting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question here as I did in my comment under to the
AWS_ACCESS_KEY_ID
setting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question here as I did in my comment under to the
AWS_ACCESS_KEY_ID
setting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question here as I did in my comment under to the
AWS_ACCESS_KEY_ID
setting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same question here as I did in my comment under to the
AWS_ACCESS_KEY_ID
setting.