Add hackernews functional integration test #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
runningcode
force-pushed
the
no/test_checkout_hackernews
branch
from
0aa8f81 to
dd4c239
Compare
runningcode
force-pushed
the
no/test_checkout_hackernews
branch
7 times, most recently
from
3d3b22a to
b49586f
Compare
runningcode
commented
Jan 17, 2025
| @@ -140,7 +140,7 @@ dependencies { | |||
| testRuntimeOnly(libs.junit.jupiter.engine) | |||
| testRuntimeOnly(libs.junit.platform.launcher) | |||
|
|
|||
| "functionalTestImplementation"(projects.emergeGradlePlugin.plugin) | |||
| "functionalTestImplementation"(project(":plugin")) | |||
There was a problem hiding this comment.
This caused the same compilation issue we were seeing before when adding this as a composite build so I just removed the generated accessor.
runningcode
changed the title
rbro112
approved these changes
Jan 17, 2025
runningcode
force-pushed
the
no/test_checkout_hackernews
branch
2 times, most recently
from
d34cc93 to
93592c8
Compare
Remove project accessors
runningcode
force-pushed
the
no/test_checkout_hackernews
branch
from
0e39253 to
1a4ade9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds this repo as a composite build to the hacker news app and builds it.
You can see in this build scan that the composite build is being applied to the
:appmodule.https://scans.gradle.com/s/fq5pdezizjitk/build-dependencies?toggled=W1sxXSxbMSwwXSxbMSwwLFs0ODVdXV0